Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DRF to 3.15.2 #8773

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Bump DRF to 3.15.2 #8773

merged 1 commit into from
Dec 5, 2024

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Dec 4, 2024

Motivation and context

I'm looking to add a Content-Security-Policy to API responses, and there were some important improvements for that in 3.15.0 (e.g. encode/django-rest-framework#8784).

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • [ ] I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features

    • Updated djangorestframework to version 3.15.2, bringing potential new features and improvements.
  • Bug Fixes

    • Enhanced compatibility and performance through the updated framework version.
  • Documentation

    • Updated comments for clarity regarding version choices and potential impacts on functionality.

@SpecLad SpecLad requested a review from Marishka17 as a code owner December 4, 2024 14:26
Copy link
Contributor

coderabbitai bot commented Dec 4, 2024

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes in this pull request involve updates to the version specifications of the djangorestframework dependency in two files: cvat/requirements/base.in and cvat/requirements/base.txt. The version constraint in base.in has been modified to allow for a newer range of compatible versions, while base.txt reflects an upgrade to the specific version of djangorestframework. Additionally, the SHA1 hash in base.txt has been updated to correspond with the changes made.

Changes

File Path Change Summary
cvat/requirements/base.in Updated djangorestframework from ~3.14.0 to >=3.15.2,<4.
cvat/requirements/base.txt Updated djangorestframework from ==3.14.0 to ==3.15.2 and changed SHA1 from 9ff984... to 275a66....

Poem

In the land of code where rabbits hop,
New versions bloom, we can't stop!
With djangorestframework now more bright,
Our features dance in the moonlight.
Hooray for updates, let’s all cheer,
For smoother paths, we hold so dear! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

I'm looking to add a `Content-Security-Policy` to API responses, and there
were some important improvements for that in 3.15.0 (e.g.
encode/django-rest-framework#8784).
Copy link

sonarqubecloud bot commented Dec 4, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.92%. Comparing base (022f45d) to head (64945e2).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8773      +/-   ##
===========================================
- Coverage    73.92%   73.92%   -0.01%     
===========================================
  Files          409      409              
  Lines        43942    43942              
  Branches      3985     3985              
===========================================
- Hits         32486    32485       -1     
- Misses       11456    11457       +1     
Components Coverage Δ
cvat-ui 78.35% <ø> (-0.01%) ⬇️
cvat-server 70.13% <ø> (ø)

@SpecLad SpecLad merged commit 683804e into cvat-ai:develop Dec 5, 2024
35 checks passed
@SpecLad SpecLad deleted the rd/bump-drf branch December 5, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants