-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade babel packages, removed outdated plugins #7914
Conversation
WalkthroughThe recent changes across the project involve the removal of specific Babel plugins ( Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/*.lock
Files selected for processing (6)
- cvat-canvas/webpack.config.cjs (1 hunks)
- cvat-canvas3d/webpack.config.cjs (1 hunks)
- cvat-core/webpack.config.cjs (1 hunks)
- cvat-data/webpack.config.cjs (1 hunks)
- cvat-ui/webpack.config.js (1 hunks)
- package.json (1 hunks)
Files skipped from review due to trivial changes (5)
- cvat-canvas/webpack.config.cjs
- cvat-core/webpack.config.cjs
- cvat-data/webpack.config.cjs
- cvat-ui/webpack.config.js
- package.json
Additional comments not posted (1)
cvat-canvas3d/webpack.config.cjs (1)
59-59
: Removal of Babel plugins: Ensure compatibility and functionality.Ensure that the removal of
@babel/plugin-proposal-class-properties
and other plugins does not affect the usage of such features in thecvat-canvas3d
module. If these features are used, consider either reintroducing the plugins or refactoring the code to not require them.Verification successful
The search for features that might require the removed Babel plugins did not produce any output. This indicates that the features provided by these plugins (class properties, optional chaining, private methods, nullish coalescing, logical assignment) are not used in the codebase.
- Ensure compatibility and functionality after the removal of Babel plugins.
- No evidence of features requiring the removed Babel plugins was found.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if the removed Babel plugins were essential for any features used in the cvat-canvas3d module. # Test: Search for features that might require the removed plugins. rg --type js --type ts 'class properties|optional chaining' ./src/typescript/Length of output: 137
Script:
#!/bin/bash # Description: Locate JavaScript and TypeScript files and verify if the removed Babel plugins were essential for any features used in the cvat-canvas3d module. # Step 1: Locate all JavaScript and TypeScript files in the repository. fd -e js -e ts # Step 2: Search for features that might require the removed plugins in the located files. rg 'class properties|optional chaining' $(fd -e js -e ts)Length of output: 45010
Script:
#!/bin/bash # Description: Verify if the removed Babel plugins were essential for any features used in the cvat-canvas3d module. # Step 1: Locate all JavaScript and TypeScript files in the repository. files=$(fd -e js -e ts) # Step 2: Search for features that might require the removed plugins in the located files. rg 'class properties|optional chaining|private methods|nullish coalescing|logical assignment' $filesLength of output: 45057
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/*.lock
Files selected for processing (1)
- package.json (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- package.json
Motivation and context
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
@babel
dependencies to newer versions for improved performance and compatibility.