Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events for importing/exporting annotations/datasets #7476

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Feb 13, 2024

Motivation and context

This can provide useful statistics on the use of this functionality.

Note that I chose to use the same scope for operations on projects, tasks and jobs, because the import/export operations work more-or-less the same on each of them and have the same parameters. It's still possible to distinguish which type of object the operation was performed on by examining the various *_id fields in the event.

How has this been tested?

Manual testing.

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

This can provide useful statistics on the use of this functionality.

Note that I chose to use the same scope for operations on projects, tasks
and jobs, because the import/export operations work more-or-less the same on
each of them and have the same parameters. It's still possible to
distinguish which type of object the operation was performed on by examining
the various `*_id` fields in the event.
@SpecLad SpecLad force-pushed the import-export-events branch from 3f00117 to c47f576 Compare February 13, 2024 14:53
@SpecLad SpecLad marked this pull request as ready for review February 13, 2024 15:04
@SpecLad SpecLad requested a review from azhavoro February 13, 2024 15:08
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Merging #7476 (c47f576) into develop (e8384f8) will decrease coverage by 0.01%.
Report is 2 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7476      +/-   ##
===========================================
- Coverage    83.55%   83.54%   -0.01%     
===========================================
  Files          375      375              
  Lines        39752    39769      +17     
  Branches      3734     3734              
===========================================
+ Hits         33213    33226      +13     
- Misses        6539     6543       +4     
Components Coverage Δ
cvat-ui 79.44% <ø> (-0.03%) ⬇️
cvat-server 87.33% <100.00%> (+0.01%) ⬆️

Copy link
Contributor

@azhavoro azhavoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SpecLad SpecLad merged commit 42be015 into cvat-ai:develop Feb 16, 2024
43 checks passed
@SpecLad SpecLad deleted the import-export-events branch February 16, 2024 13:03
SpecLad added a commit to SpecLad/cvat that referenced this pull request Feb 16, 2024
This can provide useful statistics on the use of this functionality.

Note that I chose to use the same scope for operations on projects,
tasks and jobs, because the import/export operations work more-or-less
the same on each of them and have the same parameters. It's still
possible to distinguish which type of object the operation was performed
on by examining the various `*_id` fields in the event.
@cvat-bot cvat-bot bot mentioned this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants