Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failure_ttl when enqueueing task creation job #7475

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

Marishka17
Copy link
Contributor

Motivation and context

By default failed rq jobs are kept for 1 year. It is too long and leads to keeping a lot of unnecessary results in Redis.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Marishka17 Marishka17 requested a review from SpecLad February 13, 2024 12:15
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Merging #7475 (9eb5315) into develop (ad60b82) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7475      +/-   ##
===========================================
- Coverage    83.55%   83.54%   -0.01%     
===========================================
  Files          375      375              
  Lines        39762    39762              
  Branches      3734     3734              
===========================================
- Hits         33222    33219       -3     
- Misses        6540     6543       +3     
Components Coverage Δ
cvat-ui 79.42% <ø> (-0.02%) ⬇️
cvat-server 87.34% <ø> (ø)

@SpecLad SpecLad merged commit b2a1065 into develop Feb 13, 2024
34 checks passed
@SpecLad SpecLad deleted the mk/reduce_time_for_keeping_failed_task_creation_jobs branch February 13, 2024 13:42
bsekachev pushed a commit that referenced this pull request Feb 13, 2024
By default failed rq jobs are kept for 1 year. It is too long and leads
to keeping a lot of unnecessary results in Redis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants