Add the ability to disable sign-in/sign-up in the UI #7348

Marishka17 · 2024-01-11T11:40:47Z

Motivation and context

How has this been tested?

Checklist

I submit my changes into the develop branch
I have created a changelog fragment
I have updated the documentation accordingly
I have added tests to cover my changes
I have linked related issues (see GitHub docs)
I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

…ponents based on server API

codecov · 2024-01-11T15:55:38Z

Codecov Report

Merging #7348 (659d1a6) into develop (b7cc562) will increase coverage by 0.13%.
Report is 13 commits behind head on develop.
The diff coverage is 88.18%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7348      +/-   ##
===========================================
+ Coverage    83.42%   83.56%   +0.13%     
===========================================
  Files          374      375       +1     
  Lines        39779    39762      -17     
  Branches      3729     3734       +5     
===========================================
+ Hits         33186    33226      +40     
+ Misses        6593     6536      -57

Components	Coverage Δ
cvat-ui	`79.46% <85.55%> (+0.18%)`	⬆️
cvat-server	`87.34% <100.00%> (+0.09%)`	⬆️

cvat-ui/src/reducers/index.ts

cvat-ui/src/reducers/server-api-reducer.ts

cvat-core/src/server-proxy.ts

…_on_client

…ttps://github.com/opencv/cvat into mk/add_ability_to_disable_sign_in_sign_up_on_client

cvat-ui/src/reducers/server-api-reducer.ts

…_on_client

bsekachev

LGTM, just several minor comments

cvat-core/src/api-implementation.ts

bsekachev · 2024-02-09T06:22:01Z

cvat-core/src/index.ts

@@ -65,6 +65,7 @@ export default interface CVATCore {
        setAuthData: any;
        removeAuthData: any;
        installedApps: any;
+        apiSchema: any;


Will it be possible to add something more specific than any?

We do not need to define precise type for the whole scheme, but at least what we should do it for things we use on client

bsekachev · 2024-02-09T06:39:48Z

cvat-ui/src/components/cvat-app.tsx

+                            {isPasswordResetEnabled && (
+                                <Route
+                                    exact
+                                    path='/auth/password/reset/confirm'
+                                    component={ResetPasswordPageConfirmComponent}
+                                />
+                            )}


These routes still rendered below (lines 577-582)

…ttps://github.com/opencv/cvat into mk/add_ability_to_disable_sign_in_sign_up_on_client

Co-authored-by: Boris Sekachev <boris.sekachev@yandex.ru>

egeekial · 2024-03-17T15:46:20Z

Now that this has been merged, how can I disable sign-ups in the UI?

UUVtQD · 2024-04-02T13:17:11Z

I have the same question - could either of you provide guidance on disabling self sign-up, or direct us to the relevant section in the documentation? @Marishka17 @bsekachev
Thanks!

davidblom603 · 2024-04-09T09:14:40Z

Would also like to know how to disable the self sign up

Marishka17 · 2024-04-09T10:19:41Z

Hello, @egeekial, @UUVtQD, @davidblom603, you can just comment out the corresponding endpoint on the server and rebuild CVAT from the source (docker compose -f docker-compose.yml -f docker-compose.dev.yml build).

davidblom603 · 2024-04-09T11:57:13Z

Thanks! Works great.

Store server configuration info in a state && render several auth com…

1612873

…ponents based on server API

Marishka17 requested a review from bsekachev as a code owner January 11, 2024 11:40

Marishka17 added 2 commits January 11, 2024 16:00

v14.1.0

bbb0bef

v1.62.0

8032a69

Marishka17 changed the title ~~[WIP] Add the ability to disable sign-in/sign-up in the UI~~ Add the ability to disable sign-in/sign-up in the UI Jan 11, 2024

Marishka17 requested review from klakhov and removed request for bsekachev January 11, 2024 15:04

Marishka17 added the ui/ux label Jan 11, 2024

Run CI

fabbd1d

klakhov reviewed Jan 15, 2024

View reviewed changes

cvat-ui/src/reducers/index.ts Outdated Show resolved Hide resolved

cvat-ui/src/reducers/server-api-reducer.ts Outdated Show resolved Hide resolved

cvat-core/src/server-proxy.ts Show resolved Hide resolved

Marishka17 added 5 commits January 17, 2024 11:08

Apply comments

66516d8

Merge branch 'develop' into mk/add_ability_to_disable_sign_in_sign_up…

040e2cb

…_on_client

Merge branch 'develop' into mk/add_ability_to_disable_sign_in_sign_up…

5e4c0de

…_on_client

Fix defining renderChangePasswordItem

b175c80

Merge branch 'mk/add_ability_to_disable_sign_in_sign_up_on_client' of h…

e5df19d

…ttps://github.com/opencv/cvat into mk/add_ability_to_disable_sign_in_sign_up_on_client

klakhov reviewed Jan 18, 2024

View reviewed changes

cvat-ui/src/reducers/server-api-reducer.ts Outdated Show resolved Hide resolved

Marishka17 added 2 commits January 21, 2024 22:29

Merge branch 'develop' into mk/add_ability_to_disable_sign_in_sign_up…

c13a655

…_on_client

Revert changes

20cc7b5

klakhov approved these changes Jan 23, 2024

View reviewed changes

Marishka17 and others added 2 commits February 2, 2024 13:58

Move path names to constants

9d62bc6

Merge branch 'develop' into mk/add_ability_to_disable_sign_in_sign_up…

0fe4873

…_on_client

bsekachev reviewed Feb 9, 2024

View reviewed changes

Marishka17 and others added 5 commits February 12, 2024 09:44

Merge develop

e9d97ea

Remove outdated code

80a4ada

Add type for api schema

1685f8a

Merge branch 'mk/add_ability_to_disable_sign_in_sign_up_on_client' of h…

ab29a6e

…ttps://github.com/opencv/cvat into mk/add_ability_to_disable_sign_in_sign_up_on_client

Update cvat-core/src/api-implementation.ts

659d1a6

Co-authored-by: Boris Sekachev <boris.sekachev@yandex.ru>

bsekachev approved these changes Feb 12, 2024

View reviewed changes

Marishka17 merged commit ad60b82 into develop Feb 12, 2024
34 checks passed

Marishka17 deleted the mk/add_ability_to_disable_sign_in_sign_up_on_client branch February 12, 2024 14:39

bsekachev mentioned this pull request Mar 11, 2024

How to disable self sign-up in the login page #1283

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the ability to disable sign-in/sign-up in the UI #7348

Add the ability to disable sign-in/sign-up in the UI #7348

Marishka17 commented Jan 11, 2024

codecov bot commented Jan 11, 2024 •

edited

Loading

bsekachev left a comment

bsekachev Feb 9, 2024

bsekachev Feb 9, 2024

bsekachev Feb 9, 2024

egeekial commented Mar 17, 2024

UUVtQD commented Apr 2, 2024

davidblom603 commented Apr 9, 2024

Marishka17 commented Apr 9, 2024

davidblom603 commented Apr 9, 2024

Add the ability to disable sign-in/sign-up in the UI #7348

Add the ability to disable sign-in/sign-up in the UI #7348

Conversation

Marishka17 commented Jan 11, 2024

Motivation and context

How has this been tested?

Checklist

License

codecov bot commented Jan 11, 2024 • edited Loading

Codecov Report

bsekachev left a comment

Choose a reason for hiding this comment

bsekachev Feb 9, 2024

Choose a reason for hiding this comment

bsekachev Feb 9, 2024

Choose a reason for hiding this comment

bsekachev Feb 9, 2024

Choose a reason for hiding this comment

egeekial commented Mar 17, 2024

UUVtQD commented Apr 2, 2024

davidblom603 commented Apr 9, 2024

Marishka17 commented Apr 9, 2024

davidblom603 commented Apr 9, 2024

codecov bot commented Jan 11, 2024 •

edited

Loading