Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed two issues with GT annotations #7299

Merged
merged 8 commits into from
Dec 29, 2023
Merged

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Dec 28, 2023

Motivation and context

  1. When there are conflicts on the first frame, they are not highlighted properly if CHANGE_FRAME_SUCCESS is not fired yet
  2. UI crash if to hide some annotations related to a conflict and hover mouse over the conflict

issue 1
problem 2

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev requested a review from nmanovic as a code owner December 28, 2023 11:18
@bsekachev bsekachev changed the title [WIP] Fixed two issues with GT annotations Fixed two issues with GT annotations Dec 28, 2023
@bsekachev bsekachev requested review from klakhov and removed request for nmanovic December 28, 2023 11:49
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Merging #7299 (8ad3c0d) into develop (fb610a4) will increase coverage by 0.00%.
Report is 3 commits behind head on develop.
The diff coverage is 43.75%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7299   +/-   ##
========================================
  Coverage    82.93%   82.94%           
========================================
  Files          372      372           
  Lines        39576    39570    -6     
  Branches      3688     3688           
========================================
- Hits         32824    32821    -3     
+ Misses        6752     6749    -3     
Components Coverage Δ
cvat-ui 78.39% <43.75%> (+<0.01%) ⬆️
cvat-server 87.10% <ø> (+<0.01%) ⬆️

@bsekachev bsekachev merged commit c585209 into develop Dec 29, 2023
33 checks passed
@bsekachev bsekachev deleted the bs/fixed_couple_of_gt_bugs branch January 2, 2024 12:45
@cvat-bot cvat-bot bot mentioned this pull request Jan 10, 2024
@klakhov klakhov mentioned this pull request Jan 16, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants