Removed separate loggers for each task and project #6804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SpecLad , do you have any other comments? |
SpecLad
approved these changes
Sep 5, 2023
Codecov Report
@@ Coverage Diff @@
## develop #6804 +/- ##
===========================================
+ Coverage 82.42% 82.44% +0.02%
===========================================
Files 366 366
Lines 39836 39755 -81
Branches 3545 3545
===========================================
- Hits 32835 32777 -58
+ Misses 7001 6978 -23
|
Merged
nmanovic
added a commit
that referenced
this pull request
Sep 6, 2023
### Added - Gamma correcton filter (<#6771>) - Introduced the feature to hide or show objects in review mode (<#6808>) ### Changed - \[Helm\] Database migrations are now executed as a separate job, rather than in the server pod, to mitigate the risk of data corruption when using multiple server replicas (<#6780>) - Clicking multiple times on icons in the left sidebar now toggles the corresponding popovers open and closed (<#6817>) - Transitioned to using KeyDB with FLASH for data chunk caching, replacing diskcache (<#6773>) ### Removed - Removed outdated use of hostnames when accessing Git, OpenCV, or analytics via the UI (<#6799>) - Removed the Feedback/Share component (<#6805>) ### Fixed - Resolved the issue of the canvas zooming while scrolling through the comments list in an issue (<#6758>) - Addressed the bug that allowed for multiple issue creations upon initial submission (<#6758>) - Fixed the issue of running deep learning models on non-JPEG compressed TIFF images (<#6789>) - Adjusted padding on the tasks, projects, and models pages (<#6778>) - Corrected hotkey handlers to avoid overriding default behavior when modal windows are open (<#6800>) - Resolved the need to move the mouse to activate brush or eraser effects; a single click is now sufficient (<#6800>) - Fixed a memory leak issue in the logging system (<#6804>) - Addressed a race condition that occurred during the initial creation of `secret_key.py` (<#6775>) - Eliminated duplicate log entries generated by the CVAT server (<#6766>)
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
We have a memory leak in the logging system. The patch doesn't have the aim to redesign the logging system. Only to fix the memory leak and redirect all messages into cvat_server.log file. In the future it is better to think which error messages are really helpful and send them to ClickHouse instead of a local file. It will allow to avoid any problems with multi processing. Also we have huge amount of logs inside ClickHouse. I don't see any reason to have some of them on the file system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a memory leak in the logging system. The patch doesn't have the aim to redesign the logging system. Only to fix the memory leak and redirect all messages into cvat_server.log file. In the future it is better to think which error messages are really helpful and send them to ClickHouse instead of a local file. It will allow to avoid any problems with multi processing. Also we have huge amount of logs inside ClickHouse. I don't see any reason to have some of them on the file system.