-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved lambda manager #6734
Improved lambda manager #6734
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #6734 +/- ##
===========================================
- Coverage 82.50% 82.43% -0.08%
===========================================
Files 366 366
Lines 39810 39824 +14
Branches 3538 3543 +5
===========================================
- Hits 32846 32828 -18
- Misses 6964 6996 +32
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch works well for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* First status check request after 20 seconds may confuse users making them think that something going wrong * Fixed a reason of a big amount status check requests (repeated calls for listen() method) when user go from Tasks -> any other page -> Tasks -> any other page -> Task -> any other page -> Task, etc not closing the tab. * Fixed bug when the progress invisible if the app initialized on task page * Fixed 403 code when user tries to cancel automatic annotation * Added missed schema endpoint * Added more informative progress (for queued/in progress/fail): <img width="756" alt="image" src="https://github.com/opencv/cvat/assets/40690378/f01c45a8-a460-48c0-bec4-88266bb65a2c"> <img width="980" alt="image" src="https://github.com/opencv/cvat/assets/40690378/f9e2c5ad-c2b7-4c43-8214-34236f38103b">
* First status check request after 20 seconds may confuse users making them think that something going wrong * Fixed a reason of a big amount status check requests (repeated calls for listen() method) when user go from Tasks -> any other page -> Tasks -> any other page -> Task -> any other page -> Task, etc not closing the tab. * Fixed bug when the progress invisible if the app initialized on task page * Fixed 403 code when user tries to cancel automatic annotation * Added missed schema endpoint * Added more informative progress (for queued/in progress/fail): <img width="756" alt="image" src="https://github.com/opencv/cvat/assets/40690378/f01c45a8-a460-48c0-bec4-88266bb65a2c"> <img width="980" alt="image" src="https://github.com/opencv/cvat/assets/40690378/f9e2c5ad-c2b7-4c43-8214-34236f38103b">
Motivation and context
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.