Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted plugin registration way #6533

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Adjusted plugin registration way #6533

merged 1 commit into from
Jul 21, 2023

Conversation

bsekachev
Copy link
Member

Motivation and context

Previous one can lead to race condition, because plugin is listening for getting jobs requests.
If the weights loaded later than request occurs, it does not have opened job in memory and raises an error.
Rare but possible case.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #6533 (469d851) into develop (1da005c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #6533      +/-   ##
===========================================
- Coverage    81.72%   81.72%   -0.01%     
===========================================
  Files          337      337              
  Lines        38516    38516              
  Branches      3547     3547              
===========================================
- Hits         31478    31476       -2     
- Misses        7038     7040       +2     
Components Coverage Δ
cvat-ui 75.15% <100.00%> (ø)
cvat-server 87.80% <ø> (-0.02%) ⬇️

@bsekachev bsekachev merged commit fea0dae into develop Jul 21, 2023
@bsekachev bsekachev deleted the bs/fixed_plugin_init branch July 21, 2023 10:42
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant