Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorch adapter: fix loading tasks that have already been cached #6396

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Jun 28, 2023

Motivation and context

This was broken in 4fc494f.

Add a test to cover this case.

Fixes #6047.

How has this been tested?

Unit tests.

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • [ ] I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@SpecLad SpecLad requested a review from zhiltsov-max June 28, 2023 15:51
@SpecLad SpecLad requested review from azhavoro and mdacoca as code owners June 28, 2023 15:51
@SpecLad SpecLad force-pushed the fix-cache-validation branch 2 times, most recently from 207c225 to 7bce3a0 Compare June 28, 2023 15:56
This was broken in 4fc494f.

Add a test to cover this case.
@SpecLad SpecLad force-pushed the fix-cache-validation branch from 7bce3a0 to 65999f0 Compare June 28, 2023 16:50
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #6396 (65999f0) into develop (b415fec) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #6396      +/-   ##
===========================================
+ Coverage    80.64%   80.89%   +0.25%     
===========================================
  Files          332      332              
  Lines        38438    38438              
  Branches      6923     6923              
===========================================
+ Hits         30997    31096      +99     
+ Misses        7125     7028      -97     
+ Partials       316      314       -2     
Components Coverage Δ
cvat-ui 75.13% <ø> (+0.46%) ⬆️
cvat-server 86.24% <100.00%> (+0.06%) ⬆️

@nmanovic nmanovic merged commit d950d24 into cvat-ai:develop Jun 28, 2023
@SpecLad SpecLad deleted the fix-cache-validation branch June 28, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't import dataset into Pytorch (saved locally).
3 participants