Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project quality #6367

Closed
wants to merge 157 commits into from
Closed

Project quality #6367

wants to merge 157 commits into from

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Jun 23, 2023 •
edited
Loading

Motivation and context

  • Added project quality estimation
  • Added project quality UI
  • Added tests
  • Refactored task quality UI
  • Fixed task quality settings access in org for workers
  • Fixed gt job status checks before and after task report computation
  • Task quality settings now can be initialized manually
  • Default quality settings' values now available in API schema
  • Fixed GT job creation for the whole task size
  • Added missing task/project info in job/task quality report responses
  • Fixes Typo in interface #6591
  • Fixed that only the first job page had quality results displayed in UI
  • Fixed the error with invalid data in GT job chunks

TBD:

  • Add instance-agnostic segmentation comparison (per class?) / auto-grouping for masks in segmentation comparisons
  • Add class-specific options
  • Fix invalid accuracy formula used (needs 2*TP/(DS+GT))
  • Add "included annotation types" switch

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 23, 2023
View reviewed changes
cvat/apps/iam/permissions.py
"owner": { "id": getattr(task.project.owner, 'id', None) },
"assignee": { "id": getattr(task.project.assignee, 'id', None) }
} if task.project else None,
"owner": { "id": getattr(project.owner, 'id', None) },

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.
cvat/apps/iam/permissions.py
try:
project = Project.objects.get(id=project)
except Project.DoesNotExist as ex:
raise ValidationError(str(ex))

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.
@zhiltsov-max zhiltsov-max requested a review from bsekachev as a code owner June 30, 2023 17:10
@zhiltsov-max zhiltsov-max mentioned this pull request Oct 4, 2023
Closed
@zhiltsov-max zhiltsov-max marked this pull request as draft November 2, 2023 10:52
@zhiltsov-max zhiltsov-max mentioned this pull request Nov 10, 2023
Merged
7 tasks
@klakhov klakhov mentioned this pull request Feb 5, 2024
Merged
4 tasks
@bsekachev bsekachev closed this Feb 15, 2024
@bsekachev bsekachev deleted the zm/project-quality-server branch April 22, 2024 08:37
@bsekachev bsekachev restored the zm/project-quality-server branch April 22, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpecLad SpecLad SpecLad left review comments

@bsekachev bsekachev bsekachev approved these changes

@azhavoro azhavoro Awaiting requested review from azhavoro azhavoro will be requested when the pull request is marked ready for review azhavoro is a code owner

@Marishka17 Marishka17 Awaiting requested review from Marishka17 Marishka17 will be requested when the pull request is marked ready for review Marishka17 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in interface
3 participants
@zhiltsov-max @bsekachev @SpecLad