Fix slow shutdown for the Grafana container #5746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root process of the container is `/bin/sh`, which ignores the initial `SIGTERM` that Docker sends. So Docker has to wait 10 seconds and then kill everything with `SIGKILL`. Make Grafana itself the root process instead. Grafana handles the `SIGTERM` and shuts down quickly.
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
The root process of the container is `/bin/sh`, which ignores the initial `SIGTERM` that Docker sends. So Docker has to wait 10 seconds and then kill everything with `SIGKILL`. Make Grafana itself the root process instead. Grafana handles the `SIGTERM` and shuts down quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root process of the container is
/bin/sh, which ignores the initialSIGTERMthat Docker sends. So Docker has to wait 10 seconds and then kill everything withSIGKILL.Make Grafana itself the root process instead. Grafana handles the
SIGTERMand shuts down quickly.Motivation and context
It takes 10 seconds to shut down Grafana without this change, and less than 1 with it.
How has this been tested?
docker compose downChecklist
developbranch[ ] I have added a description of my changes into the CHANGELOG file[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.