Debug health check #5587
Merged
Debug health check #5587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@azhavoro , can we customize the error message in the PR? |
nmanovic
reviewed
Jan 16, 2023
cvat-ui/src/utils/enviroment.ts
Outdated
| @@ -29,3 +29,7 @@ export function customWaViewHit(pageName?: string, queryString?: string, hashInf | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| export function isPublicInstance(): boolean { | |||
There was a problem hiding this comment.
I don't think that it is a right solution. Probably HealthCheck endpoint can return extra information. Need to think how to implement that. Another solution is to have the message as a variable in settings. Please think and propose the best solution.
|
@azhavoro , could you please resolve the conflict? |
bsekachev
reviewed
Jan 17, 2023
| if (Object.prototype.hasOwnProperty.call(data, checkName) && | ||
| checkName !== 'Cache backend: media' && | ||
| data[checkName] !== 'working') { | ||
| isHealthy = false; |
There was a problem hiding this comment.
If it is a temporary workaround, let's keep a comment about it here
Co-authored-by: Boris Sekachev <boris.sekachev@yandex.ru>
Co-authored-by: Boris Sekachev <boris.sekachev@yandex.ru>
Co-authored-by: Boris Sekachev <boris.sekachev@yandex.ru>
nmanovic
approved these changes
Jan 17, 2023
<!-- Raised an issue to propose your change (https://github.com/cvat-ai/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [CONTRIBUTION](https://github.com/cvat-ai/cvat/blob/develop/CONTRIBUTING.md) guide. --> <!-- Provide a general summary of your changes in the Title above --> ### Implementation & using Regular import from the whole cvat-ui-app, like: ```import consts from 'config';``` To change config for app.cvat.ui, need to specify a new file during webpack build time: ```UI_APP_CONFIG='/home/bsekachev/config.override.tsx' yarn build``` In development: ``UI_APP_CONFIG='/home/bsekachev/config.override.tsx' yarn start:cvat-ui`` Override file content in this case is simple: ```ts import config from './cvat/cvat-ui/src/config'; config.HEALH_CHECK_RETRIES = 5; export default { ...config, NEW_CONFIG_VARIABLE: 'test value', }; ``` Implemented via webpack aliases: ``` resolve { alias: { config$: appConfigFile, } } ``` + No typescript errors in code, because default ``app-config`` exists in ``src``. Co-authored-by: Andrey Zhavoronkov <andrey@cvat.ai>
bsekachev
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.