Fix pagination in some endpoints #5557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d827a8 to
fbcc345
Compare
|
@zhiltsov-max , @bsekachev , could you please look at tests? |
…zm/improve-some-endpoints
7 tasks
nmanovic
reviewed
Jan 19, 2023
| dimension = serializers.CharField(max_length=2, source='segment.task.dimension') | ||
| labels = LabelSerializer(many=True, source='get_labels') | ||
| assignee = BasicUserSerializer(allow_null=True, read_only=True) | ||
| dimension = serializers.CharField(max_length=2, source='segment.task.dimension', read_only=True) |
There was a problem hiding this comment.
@zhiltsov-max , why do we need read_only=True here if below read_only_fields is specified?
There was a problem hiding this comment.
For some reason, the fields marked with read_only=True are "required" in the generated schema otherwise, even though they are mentioned in Meta.read_only_fields. I suspect this is because they are overridden, note that the other fields have the ReadOnlyField type.
nmanovic
approved these changes
Jan 19, 2023
2 tasks
2 tasks
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
- Added missing pagination or page parameters in `/projects/{id}/tasks`,
`/tasks/{id}/jobs`, `/jobs/{id}/issues`, `/jobs/{id}/commits`,
`/issues/{id}/comments`, `/organizations`
- Updated SDK, tests and UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
/projects/{id}/tasks,/tasks/{id}/jobs,/jobs/{id}/issues,/jobs/{id}/commits,/issues/{id}/comments,/organizationsHow has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.