test task - regression testing to export tasks #5519
Conversation
|
@bsekachev , could you please look at the PR? |
| }); | ||
|
|
||
| context('Export task inner.', { browser: '!firefox' }, () => { | ||
| const caseId = '999'; |
There was a problem hiding this comment.
Should refer to real issue. If no issue exist, this does not make sense.
| cy.deleteTask(taskName); | ||
| }); | ||
|
|
||
| describe(`Testing "${taskName}"`, () => { |
There was a problem hiding this comment.
Better to be more specific here. It is not clear what we are testing. Using string template is not the best option here because it makes code more difficult to read and understand.
| it('Open a task', () => { | ||
| cy.openTask(taskName); | ||
| }); |
There was a problem hiding this comment.
Should be a part of before probably, because we don't test opening a task here
| // Start writing your Cypress tests below! | ||
| // If you're unfamiliar with how Cypress works, | ||
| // check out the link below and learn how to write your first test: | ||
| // https://on.cypress.io/writing-first-test |
There was a problem hiding this comment.
We need to put a lincese header here instead of default Cypress text:
// Copyright (C) 2022 CVAT.ai Corporation
//
// SPDX-License-Identifier: MIT
|
|
||
| /// <reference types="cypress" /> | ||
|
|
||
| Cypress.Commands.add('exportInnerTask', ({ |
There was a problem hiding this comment.
There is a dedicated files for Cypress commands definition:
tests/cypress/support/*.js
| order, | ||
| imageClick = false, | ||
| }) => { | ||
| const orderId = Number.isNaN(parseInt(order, 10)) ? 0 : parseInt(order, 10); |
There was a problem hiding this comment.
| const orderId = Number.isNaN(parseInt(order, 10)) ? 0 : parseInt(order, 10); | |
| const orderId = +order || 0; |
But generally, if we need an integer here, passing a string to this command does not make sense
| const imagesFolder = `cypress/fixtures/${imageFileName}`; | ||
| const directoryToArchive = imagesFolder; | ||
| const newLabelName = 'person'; | ||
| const exportOrders = [0, 1, 2]; |
There was a problem hiding this comment.
Choosing an export format by its order is not robust option I think. Order can be changed easily.
Better to choose by name
| @@ -0,0 +1,138 @@ | |||
| // Start writing your Cypress tests below! | |||
There was a problem hiding this comment.
- Please check comments from the previous file, many of them applicable here
- A lot of code dublication, I would prefer rework it somehow to reduce it. Maybe to combine these two tests into the one.
|
Looks like the test has not been run on CI because of configuration of |
|
@AparinAA , thanks for PR. I will close it. |
|
OK. I can fix the wrong if needed |
Added test to #5396