Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the missing env variable issue #5467

Merged
merged 7 commits into from
Dec 16, 2022
Merged

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Dec 14, 2022

Motivation and context

Fixes #5448, #5453, #5457

  • Relaxed env var requirements in the images, no mandatory ones
  • RQ workers now use a custom python class for remote debugging
  • Factored out common remote debugging implementation

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@zhiltsov-max zhiltsov-max changed the title [WIP] Fix the missing env variable issue Fix the missing env variable issue Dec 15, 2022
@knidarkness
Copy link

Is there any chance for this to be merged soon? We are blocked by the issue this PR solves, yet we need webhooks support, which is not yet in the master branch, so I was wondering if there's something blocking this PR.

Thanks

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit f6d2a8f into develop Dec 16, 2022
@nmanovic nmanovic deleted the zm/fix-missing-variable branch December 16, 2022 13:27
@DeepBlue27
Copy link

this fixed nothing :\ the problem persist

@zhiltsov-max
Copy link
Contributor Author

zhiltsov-max commented Dec 16, 2022

@DeepBlue27 , @knidarkness
Hi, please run docker pull cvat/server:dev and restart the containers with docker-compose down && docker-compose up -d to update your local Docker images to the fixed version. If you're using custom images, please rebuild them with docker-compose -f docker-compose.yml -f docker-compose.dev.yml build and restart the containers.

mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
Fixes cvat-ai#5448, cvat-ai#5453, cvat-ai#5457

- Relaxed env var requirements in the images, no mandatory ones
- RQ workers now use a custom python class for remote debugging
- Factored out common remote debugging implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create a new task
4 participants