SDK: fix Project.import_dataset incorrectly waiting for completion
#5459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You have to use the `import_status` action in order to query the input
status. Otherwise, the `/api/projects/{id}/dataset/` endpoint initiates a
dataset export. Currently, `import_dataset` inadvertently monitors the
status of that export, not the original import.
2acca28 to
95ff712
Compare
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
…vat-ai#5459) You have to use the `import_status` action in order to query the input status. Otherwise, the `/api/projects/{id}/dataset/` endpoint initiates a dataset export. Currently, `import_dataset` inadvertently monitors the status of that export, not the original import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You have to use the
import_statusaction in order to query the input status. Otherwise, the/api/projects/{id}/dataset/endpoint initiates a dataset export. Currently,import_datasetinadvertently monitors the status of that export, not the original import.Motivation and context
This bug breaks the CI run for #5456. I've no idea why it hadn't caused the test suite to fail before...
How has this been tested?
Unit tests.
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (read github docs)[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.