Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job access checks for model invocations #5392

Merged
merged 19 commits into from
Dec 5, 2022
Merged

Add job access checks for model invocations #5392

merged 19 commits into from
Dec 5, 2022

Conversation

zhiltsov-max
Copy link
Contributor

Motivation and context

Fixes #4996

  • Added job access checks for model launches in the interactive mode

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

try:
obj = Job.objects.get(id=job_id)
except Job.DoesNotExist as ex:
raise ValidationError(str(ex))

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.
@zhiltsov-max zhiltsov-max changed the title [WIP] Add job access checks for model invocations Add job access checks for model invocations Dec 1, 2022
@zhiltsov-max
Copy link
Contributor Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

❌ Some checks failed
📄 See logs here

cvat/apps/iam/permissions.py Outdated Show resolved Hide resolved
cvat/apps/lambda_manager/tests/test_lambda.py Outdated Show resolved Hide resolved
cvat/apps/lambda_manager/tests/test_lambda.py Outdated Show resolved Hide resolved
cvat/apps/lambda_manager/views.py Outdated Show resolved Hide resolved
cvat/apps/lambda_manager/views.py Outdated Show resolved Hide resolved
cvat/apps/lambda_manager/views.py Show resolved Hide resolved
@nmanovic nmanovic merged commit cacb997 into develop Dec 5, 2022
@nmanovic nmanovic deleted the zm/fix-4996 branch December 5, 2022 10:46
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Jul 1, 2023
Fixes cvat-ai#4996
- Added job access checks for model launches in the interactive mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worker and supervisor unable to auto annotate with models, 403 error
3 participants