Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added smooth image option #3933

Merged
merged 5 commits into from
Nov 24, 2021
Merged

Added smooth image option #3933

merged 5 commits into from
Nov 24, 2021

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Nov 22, 2021 •
edited
Loading

Added switcher
image

Smoothed:
image

Pixelized:
image

Motivation and context

Customer request

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev
Copy link
Member Author

Hi, @nstolyarov

This is PR regarding one of your requests. Will such the feature satisfy your needs?

@bsekachev bsekachev requested a review from nmanovic as a code owner November 22, 2021 13:30
@nstolyarov
Copy link

nstolyarov commented Nov 22, 2021 •
edited
Loading

Hi, @nstolyarov

This is PR regarding one of your requests. Will such the feature satisfy your needs?

Hi, @bsekachev

Yes! This is exactly the feature that we need! Thank you.

@bsekachev
Copy link
Member Author

@ActiveChooN could you please review the patch?

nmanovic
nmanovic approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I didn't test the PR.

@nmanovic nmanovic merged commit c6ed6d1 into develop Nov 24, 2021
@nmanovic nmanovic deleted the bs/smooth_image_option branch November 24, 2021 08:30
@bsekachev
Copy link
Member Author

@TOsmanov @aschernov

Hi, guys. Could you please look at this patch and update documentation accordingly?

@bsekachev
Copy link
Member Author

Hi, @dvkruchinin
Could you please write a test for this feature? Test is simple. When an option disabled, element cvat_canvas_background should have css property image-rendering set to crisp-edges or pixelated

@TOsmanov
Copy link
Contributor

@TOsmanov @aschernov

Hi, guys. Could you please look at this patch and update documentation accordingly?

@bsekachev Hi. yes, sure

@dvkruchinin
Copy link
Contributor

Hi, @dvkruchinin Could you please write a test for this feature? Test is simple. When an option disabled, element cvat_canvas_background should have css property image-rendering set to crisp-edges or pixelated

Hi. Sure. A test will be prepared.

@TOsmanov TOsmanov mentioned this pull request Nov 25, 2021
Merged
8 tasks
@nmanovic nmanovic mentioned this pull request Nov 26, 2021
Closed
sarikaya added a commit to roboduels/cvat that referenced this pull request Dec 4, 2021
@sarikaya
Merge branch 'develop' of https://github.com/openvinotoolkit/cvat int…
e219323 
…o openvinotoolkit-develop

* 'develop' of https://github.com/openvinotoolkit/cvat: (181 commits)
  Cypress. Update case 105. Add check "Google cloud storage" provider fields. (cvat-ai#3980)
  Cypress. Fix case 108 for Firefox. (cvat-ai#3981)
  update project section (cvat-ai#3979)
  Cypress. Test "Rotated bounding boxes" (cvat-ai#3961)
  Issue deleting (cvat-ai#3952)
  Remove key_file_path field (cvat-ai#3959)
  update the doc for change default hostname or port (cvat-ai#3915)
  CVAT_server. Test for "Project updated time". (cvat-ai#3953)
  fix: cvat/requirements/base.txt to reduce vulnerabilities (cvat-ai#3970)
  Fix notification (cvat-ai#3960)
  Update documentation for China users (cvat-ai#3946)
  Support GCS (cvat-ai#3919)
  Cypress. Update the test for check issue 3810. (cvat-ai#3900)
  Update the documentation about the smooth image option (cvat-ai#3947)
  Project tasks pagination (cvat-ai#3910)
  Update documentation about review mode (cvat-ai#3944)
  Preserve the order of the label attributes in the object item details. (cvat-ai#3945)
  Added smooth image option (cvat-ai#3933)
  Fixed issue: autoborder points are visible for invisible shapes (cvat-ai#3931)
  Add FiftyOne to partners list (cvat-ai#3943)
  ...
sarikaya added a commit to roboduels/cvat that referenced this pull request Dec 4, 2021
@sarikaya
Merge branch 'openvinotoolkit-develop' into develop
28d8021 
* openvinotoolkit-develop: (181 commits)
  Cypress. Update case 105. Add check "Google cloud storage" provider fields. (cvat-ai#3980)
  Cypress. Fix case 108 for Firefox. (cvat-ai#3981)
  update project section (cvat-ai#3979)
  Cypress. Test "Rotated bounding boxes" (cvat-ai#3961)
  Issue deleting (cvat-ai#3952)
  Remove key_file_path field (cvat-ai#3959)
  update the doc for change default hostname or port (cvat-ai#3915)
  CVAT_server. Test for "Project updated time". (cvat-ai#3953)
  fix: cvat/requirements/base.txt to reduce vulnerabilities (cvat-ai#3970)
  Fix notification (cvat-ai#3960)
  Update documentation for China users (cvat-ai#3946)
  Support GCS (cvat-ai#3919)
  Cypress. Update the test for check issue 3810. (cvat-ai#3900)
  Update the documentation about the smooth image option (cvat-ai#3947)
  Project tasks pagination (cvat-ai#3910)
  Update documentation about review mode (cvat-ai#3944)
  Preserve the order of the label attributes in the object item details. (cvat-ai#3945)
  Added smooth image option (cvat-ai#3933)
  Fixed issue: autoborder points are visible for invisible shapes (cvat-ai#3931)
  Add FiftyOne to partners list (cvat-ai#3943)
  ...
@dvkruchinin dvkruchinin mentioned this pull request Dec 10, 2021
Merged
8 tasks
@nmanovic nmanovic mentioned this pull request Mar 4, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmanovic nmanovic nmanovic approved these changes

@ActiveChooN ActiveChooN ActiveChooN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bsekachev @nstolyarov @TOsmanov @dvkruchinin @ActiveChooN @nmanovic