Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress. Exclude some files from instrumentation. #3349

Conversation

dvkruchinin
Copy link
Contributor

Motivation and context

Increase code coverage by about 1%

File name Comment
/cvat-ui/src/actions/models-actions.ts The code is not called in the standard CVAT build
/cvat-ui/src/actions/boundaries-actions.ts If the application is running correctly, the code is not called.
/cvat-ui/src/containers/models-page/models-page.tsx The code is not called in the standard CVAT build
/cvat-ui/src/reducers/models-reducer.ts The code is not called in the standard CVAT build
/cvat-ui/src/utils/platform-checker.ts Measure coverage conducted on a supported platform

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@dvkruchinin dvkruchinin requested a review from azhavoro as a code owner June 21, 2021 11:49
ActiveChooN
ActiveChooN previously approved these changes Jun 21, 2021
@nmanovic
Copy link
Contributor

@dvkruchinin , could we include testing of the page with models?

@dvkruchinin
Copy link
Contributor Author

@nmanovic

could we include testing of the page with models?

Yes. I think it will be enough to change the CVAT build command in CI.

@nmanovic
Copy link
Contributor

@nmanovic

could we include testing of the page with models?

Yes. I think it will be enough to change the CVAT build command in CI.

Let's do that in the case instead of excluding files from the coverage report.

@dvkruchinin
Copy link
Contributor Author

Let's do that in the case instead of excluding files from the coverage report.

Ok.
But I think it's worth keeping the files

/cvat-ui/src/actions/boundaries-actions.ts
/cvat-ui/src/utils/platform-checker.ts

Since they will not be covered

@nmanovic
Copy link
Contributor

Let's do that in the case instead of excluding files from the coverage report.

Ok.
But I think it's worth keeping the files

/cvat-ui/src/actions/boundaries-actions.ts
/cvat-ui/src/utils/platform-checker.ts

Since they will not be covered

Agree

@nmanovic nmanovic merged commit e76b0ea into cvat-ai:develop Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants