Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress. Case 44. Adding additional checks. #3312

Conversation

dvkruchinin
Copy link
Contributor

Motivation and context

This test often fails due to the aria-label="edit" visibility check when changing label attributes.

Timed out retrying after 25000ms: `cy.should()` failed because this element is detached from the DOM.

Adding additional checks for the existence and visibility of the parent elements should solve this problem. This version of the updated test was tested in my fork by restarting jobs about 40 times. The test never failed with an error.

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@dvkruchinin dvkruchinin requested a review from azhavoro as a code owner June 10, 2021 05:38
@bsekachev bsekachev self-assigned this Jun 10, 2021
@bsekachev bsekachev merged commit 7699bd3 into cvat-ai:develop Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants