Support of context images for 2D tasks #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
April 20, 2021 20:11
Sure. I created the corresponding task. |
added 2 commits
April 23, 2021 11:59
bsekachev
commented
May 14, 2021
utils/dataset_manifest/utils.py
Outdated
Comment on lines
55
to
80
| related_images = {} | ||
| latest_dirname = '' | ||
| related_images_exist = False | ||
|
|
||
| for image_path in sorted(image_paths): | ||
| rel_image_path = os.path.relpath(image_path, root_path) | ||
| dirname = os.path.dirname(image_path) | ||
| related_images_dirname = os.path.join(dirname, 'related_images') | ||
| related_images[rel_image_path] = [] | ||
|
|
||
| if latest_dirname == dirname and not related_images_exist: | ||
| continue | ||
| elif latest_dirname != dirname: | ||
| # Update some data applicable for a subset of paths (within the current dirname) | ||
| latest_dirname = dirname | ||
| related_images_exist = os.path.isdir(related_images_dirname) | ||
|
|
||
| if related_images_exist: | ||
| related_images_dirname = os.path.join( | ||
| related_images_dirname, '_'.join(os.path.basename(image_path).rsplit('.', 1)) | ||
| ) | ||
|
|
||
| if os.path.isdir(related_images_dirname): | ||
| related_images[rel_image_path] = _prepare_context_list(_list_and_join(related_images_dirname), root_path) | ||
| return related_images |
There was a problem hiding this comment.
This is updated implementation for 2D. We do not find context images for images where parent directory does not include "related_images". Something like this (and some other optimizations) work for 3D case.
nmanovic
reviewed
May 18, 2021
| for image_path in image_paths: | ||
| # .bin files are expected to be converted to .pcd before this code | ||
| if os.path.splitext(image_path)[1].lower() == '.pcd': |
There was a problem hiding this comment.
@bsekachev , from my perspective it is better to have an explicit flag. But let's live with the solution.
nmanovic
previously approved these changes
May 18, 2021
|
@bsekachev , please check if images are in a subdirectory inside an archive, the PR works. |
|
@bsekachev , if |
2 tasks
2 tasks
8 tasks
8 tasks
This was referenced Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Resolved #3049
Expected structure is like this (example):
You can upload this structure using an archive or from an attached shared storage.
Working gif:
Need documentation. @TOsmanov, could you please take a look after the PR will be merged?
Need tests. @dvkruchinin , could you please take a look after the PR will be merged?
How has this been tested?
Manual testing
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.