Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unsupported methods #3008

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Fixed unsupported methods #3008

merged 1 commit into from
Mar 24, 2021

Conversation

bsekachev
Copy link
Member

Motivation and context

Using .replaceAll was not the best solution because it is not well supported.
The patch changes method to replace( with global regex

.replaceAll support
Screenshot from 2021-03-24 13-31-03

.replace support
Screenshot from 2021-03-24 13-30-42

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Mar 24, 2021
@bsekachev bsekachev requested a review from ActiveChooN March 24, 2021 10:33
@bsekachev
Copy link
Member Author

@ActiveChooN

Please, look at this patch ASAP. It is quite critical for our users.

@bsekachev bsekachev merged commit 73d7fd0 into develop Mar 24, 2021
@bsekachev
Copy link
Member Author

@azhavoro

Could you please update cvat.org and the internal server with this fix?
We get a lot of related exceptions and looks like some users cannot open CVAT after previous updating.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.257% when pulling f3fbe14 on bs/fixed_unsupported_methods into e41c301 on develop.

@bsekachev bsekachev deleted the bs/fixed_unsupported_methods branch March 24, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants