Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Server tests. Dataset manager. #3004

Closed
wants to merge 24 commits into from

Conversation

mzuevx
Copy link
Contributor

@mzuevx mzuevx commented Mar 23, 2021

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Dmitriy Oparin and others added 10 commits March 12, 2021 09:49
Commented out tests passed Ok
Uncommented tests failed if launched in single test session, seems that tasks created via POST request to url /api/v1/tasks have the same id (1)
@mzuevx mzuevx requested a review from zhiltsov-max as a code owner March 23, 2021 22:28
# create task with annotations
images = self._generate_task_images(3)
task = self._create_task(tasks["main"], images)
self._create_annotations(task, dump_format_name, "default")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_create_annotations function and other tests use "dafault"

@zhiltsov-max
Copy link
Contributor

How this branch is related to #2943? Please read my comments there.

@mzuevx
Copy link
Contributor Author

mzuevx commented Mar 24, 2021

@zhiltsov-max , this is fork of #2943
Your comments in #2943 will be processed.

@mzuevx mzuevx changed the title WIP Mz/server test dataset manager [WIP] Server tests. Dataset manager. Mar 24, 2021
@coveralls
Copy link

coveralls commented Mar 25, 2021

Coverage Status

Coverage increased (+0.9%) to 75.889% when pulling cfe22a4 on mzuevx:mz/server_test_dataset_manager into 57385fa on openvinotoolkit:develop.

# url_upload = self._generate_url_upload_tasks_annotations(task_id, upload_format_name)
# with open(file_zip_name_after_change, 'rb') as binary_file:
# with self.assertRaisesRegex(ValueError, f"Label '{wrong_label}' is not registered for this task"):
# response = self._upload_file(url_upload, binary_file, self.admin)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably shouldn't try to catch the exception here, since it was handled earlier.

@yasakova-anastasia
Copy link
Contributor

We have another PR for these tests: #3192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants