Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project task subsets #2774

Merged
merged 9 commits into from
Feb 15, 2021
Merged

Project task subsets #2774

merged 9 commits into from
Feb 15, 2021

Conversation

ActiveChooN
Copy link
Contributor

@ActiveChooN ActiveChooN commented Feb 5, 2021

Motivation and context

This PR provide new field in task such as subset to divide project tasks in some subsets f.e. train/test/val will be. This field will be used in the project dump in future project feature implementation.

изображение

изображение

изображение

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

coveralls commented Feb 5, 2021

Coverage Status

Coverage increased (+1.09%) to 70.851% when pulling 7e22113 on dk/task-subset-in-project into e382313 on develop.

@bsekachev
Copy link
Member

@vnishukov Please, test the PR and review the code.
Do you have enough time to do it this week?

@bsekachev bsekachev requested a review from vnishukov February 10, 2021 09:46
vnishukov
vnishukov previously approved these changes Feb 15, 2021
@@ -222,30 +216,26 @@
owner: isString,
search: isString,
status: isEnum.bind(TaskStatus),
without_tasks: isBoolean,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why snake case here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to we rely on fields in server requests params. Added replacing.

@bsekachev bsekachev merged commit e43707d into develop Feb 15, 2021
@bsekachev bsekachev deleted the dk/task-subset-in-project branch February 15, 2021 11:06
kenu pushed a commit to kenu/cvat that referenced this pull request Feb 23, 2021
* Added task project subsets

* Added components list key

* Added subset field resetting and subset header

* Added CHANGELOG and increased npm package version

* Added replacing camelcase to snake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants