-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HRNet stopped working after NumPy 1.24 #5571
Comments
@rodrigoberriel , thanks for the report. Could you please send us a PR? |
Done! |
nmanovic
pushed a commit
that referenced
this issue
Mar 23, 2023
HRNet uses `np.int` which throws an error for NumPy >= 1.24, because its deprecation was finally expired. This PR creates an additional step during HRNet function image build, downgrading NumPy for a version < 1.24. ### Motivation and context Closes #5571.
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this issue
Jul 1, 2023
HRNet uses `np.int` which throws an error for NumPy >= 1.24, because its deprecation was finally expired. This PR creates an additional step during HRNet function image build, downgrading NumPy for a version < 1.24. ### Motivation and context Closes cvat-ai#5571.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My actions before raising this issue
Three weeks ago NumPy 1.24.0 was released and they finally expired the deprecation for
np.int
introduced in Numpy 1.20:Therefore, using
np.int
now results in an error instead of a warning. It just happens that HRNet usesnp.int
and the NumPy version is not pinned in theirrequirements.txt
. So, if you try to deploy HRNet today, it will pull NumPy >= 1.24 and the following error will be thrown:Expected Behaviour
HRNet should be deployed with success.
Current Behaviour
The HRNet does not deploy successfully as of 3 weeks ago.
Possible Solution
Add an extra step to function-gpu.yaml, downgrading NumPy:
pip install "numpy<1.24"
.I tested it in my environment and it worked. I can submit a PR if this approach is okay.
Alternative:
requirements.txt
before installing it, replacing thenumpy
line tonumpy<1.24
.Steps to Reproduce (for bugs)
docker logs nuclio-nuclio-pth-saic-vul-hrnet
Context
I re-deployed HRNet after #5570, and it didn't work.
Your Environment
git log -1
): 43ed0a2docker version
(e.g. Docker 17.0.05): 20.10.18The text was updated successfully, but these errors were encountered: