Skip to content

Commit

Permalink
Hotfix: excessive scrollbar on quality page (#8729)
Browse files Browse the repository at this point in the history
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
Fix for scaling in #8698 produced excessive scrollbar even for 100%
(for quality placeholder and management tab with full table of gt
frames)

![image](https://github.com/user-attachments/assets/0f9e11d4-4d56-4920-83e8-033d5b175eb6)

![image](https://github.com/user-attachments/assets/d387173e-d35f-492e-8c1d-cfbf8bf91628)

This hotfix fixes it. Scrollbar should be visible only on scaling
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [ ] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))

### License

- [ ] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
  • Loading branch information
klakhov authored Nov 21, 2024
1 parent 228b676 commit 3d7e2c7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
height: $grid-unit-size * 77;

.ant-card-body {
height: 80%;
height: 75%;
}
}

Expand Down
5 changes: 2 additions & 3 deletions cvat-ui/src/components/quality-control/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ $excluded-background: #d9d9d973;
}
}


.cvat-frame-allocation-header {
margin-bottom: 0;
font-size: 20px;
Expand Down Expand Up @@ -132,14 +131,14 @@ $excluded-background: #d9d9d973;
}

.cvat-frame-allocation-table .ant-table-container {
max-height: calc(100vh - $grid-unit-size * 60);
max-height: calc(100vh - $grid-unit-size * 61);
overflow-y: auto;
}

.cvat-task-control-tabs {
.ant-tabs-tabpane {
@extend .cvat-quality-scrollbar;

max-height: calc(100vh - $grid-unit-size * 35);
height: calc(100vh - $grid-unit-size * 33);
}
}

0 comments on commit 3d7e2c7

Please sign in to comment.