Prohibit wildcard import in pylint (#8893)

cvat-ai · Jan 30, 2025 · 2ca90b0 · 2ca90b0
1 parent 3bc92da
commit 2ca90b0
Show file tree

Hide file tree

Showing 11 changed files with 24 additions and 15 deletions.
diff --git a/.pylintrc b/.pylintrc
@@ -287,7 +287,6 @@ disable=raw-checker-failed,
         raise-missing-from,
         raising-format-tuple,
         wrong-exception-operation,
-        wildcard-import,
         deprecated-module,
         import-self,
         preferred-module,
@@ -516,7 +515,8 @@ enable=singleton-comparison,
        logging-unsupported-format,
        logging-format-truncated,
        logging-too-many-args,
-       logging-too-few-args
+       logging-too-few-args,
+       wildcard-import
 
 
 [BASIC]

diff --git a/cvat-sdk/cvat_sdk/models.py b/cvat-sdk/cvat_sdk/models.py
@@ -2,4 +2,5 @@
 #
 # SPDX-License-Identifier: MIT
 
-from cvat_sdk.api_client.models import *  # pylint: disable=unused-import,redefined-builtin
+# Reexport symbols for public SDK API
+from cvat_sdk.api_client.models import *  # pylint: disable=wildcard-import
diff --git a/cvat/apps/engine/__init__.py b/cvat/apps/engine/__init__.py
@@ -3,5 +3,5 @@
 #
 # SPDX-License-Identifier: MIT
 
-
-from .schema import *  # force import of declared symbols
+# Force execution of declared symbols
+from .schema import *  # pylint: disable=wildcard-import
diff --git a/cvat/settings/development.py b/cvat/settings/development.py
@@ -2,7 +2,8 @@
 #
 # SPDX-License-Identifier: MIT
 
-from .base import *
+# Inherit parent config
+from .base import *  # pylint: disable=wildcard-import
 
 # SECURITY WARNING: don't run with debug turned on in production!
 DEBUG = True

diff --git a/cvat/settings/email_settings.py b/cvat/settings/email_settings.py
@@ -3,7 +3,8 @@
 #
 # SPDX-License-Identifier: MIT
 
-from cvat.settings.production import *
+# Inherit parent config
+from cvat.settings.production import *  # pylint: disable=wildcard-import
 
 # https://github.com/pennersr/django-allauth
 ACCOUNT_AUTHENTICATION_METHOD = 'username_email'

diff --git a/cvat/settings/production.py b/cvat/settings/production.py
@@ -2,7 +2,8 @@
 #
 # SPDX-License-Identifier: MIT
 
-from .base import *
+# Inherit parent config
+from .base import *  # pylint: disable=wildcard-import
 
 DEBUG = False
 

diff --git a/cvat/settings/testing.py b/cvat/settings/testing.py
@@ -4,7 +4,8 @@
 
 import tempfile
 
-from .development import *
+# Inherit parent config
+from .development import *  # pylint: disable=wildcard-import
 
 DATABASES = {
     'default': {

diff --git a/cvat/settings/testing_rest.py b/cvat/settings/testing_rest.py
@@ -2,7 +2,8 @@
 #
 # SPDX-License-Identifier: MIT
 
-from cvat.settings.production import *
+# Inherit parent config
+from cvat.settings.production import *  # pylint: disable=wildcard-import
 
 # We use MD5 password hasher instead of default PBKDF2 here to speed up REST API tests,
 # because the current implementation of the tests requires authentication in each test case

diff --git a/tests/python/cli/conftest.py b/tests/python/cli/conftest.py
@@ -2,4 +2,5 @@
 #
 # SPDX-License-Identifier: MIT
 
-from sdk.fixtures import *  # pylint: disable=unused-import
+# Force execution of fixture definitions
+from sdk.fixtures import *  # pylint: disable=wildcard-import
diff --git a/tests/python/conftest.py b/tests/python/conftest.py
@@ -2,6 +2,7 @@
 #
 # SPDX-License-Identifier: MIT
 
-from shared.fixtures.data import *
-from shared.fixtures.init import *
-from shared.fixtures.util import *
+# Force execution of fixture definitions
+from shared.fixtures.data import *  # pylint: disable=wildcard-import
+from shared.fixtures.init import *  # pylint: disable=wildcard-import
+from shared.fixtures.util import *  # pylint: disable=wildcard-import
diff --git a/tests/python/sdk/conftest.py b/tests/python/sdk/conftest.py
@@ -2,4 +2,5 @@
 #
 # SPDX-License-Identifier: MIT
 
-from .fixtures import *
+# Force execution of fixture definitions
+from .fixtures import *  # pylint: disable=wildcard-import