-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write roman ts and repeats #1393
Write roman ts and repeats #1393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments on removing tested/documented code without replacements.
Ok, noted. The mass deletions are an attempt at simpler solutions and strike me as a good fit for the contributing docs' invitation to remove 30+ lines when 1 will do nicely. All the same, while I have misgiving about For reference, the process is about the addition of specific tokens in a specific order.
|
…writeRoman_ts_and_reapeats
This PR has been superseded by another, subsequent one for the same issue at #1435. I wonder if there's an integration action for checking new PRs against those in progress that would prevent this? In any case, I've been through to pick them apart and what remains as new here is simply:
A small contributions for sure, but a positive one, and makes this (1393) ready for closure. Let me know if you spot any issues / anything missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contributions here are enough to still merge after the changes requested are made.
If you know of an easy tool that can prevent duplicated work, happy to add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Write complement to #1378 along with a bit of clean up