Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Musicxml export] Preserve whitespace in TextBox #1331

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

jacobtylerwalls
Copy link
Member

I found that xml:space="preserve" is the way to preserve the display of newlines in a <credit-words>.
music21 was splitting text content on newlines and creating distinct <credit-word> elements, but without changing the position attributes, they were superimposed:

Before
Screen Shot 2022-06-29 at 11 24 24 AM

After
Screen Shot 2022-06-29 at 11 24 31 AM

@coveralls
Copy link

coveralls commented Jun 29, 2022

Coverage Status

Coverage decreased (-0.0002%) to 93.054% when pulling 8b29eee on jacobtylerwalls:credit-words-fix into c46bde4 on cuthbertLab:master.

@mscuthbert
Copy link
Member

Oh, this is so much better. (Btw -- what piece is that? I have a vague memory of encoding it, but no clue!)

@mscuthbert mscuthbert merged commit 2dccb5b into cuthbertLab:master Jul 4, 2022
@jacobtylerwalls
Copy link
Member Author

It's the Amy Beach choral work in the corpus.

@jacobtylerwalls jacobtylerwalls deleted the credit-words-fix branch July 4, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants