Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config entry for custom VAT #164

Closed

Conversation

catshapednoodles
Copy link

Added a config entry to overwrite the hardcoded VAT values. As discussed in #163, this would be a better solution than just temporarily changing the value. This way all users have a way to easily change VAT values if their situation calls for that, without changing the code.

Also added UI translations for other languages than English, but I don't know if they are any good since I got them from Google Translate.

@Hellowlol
Copy link
Collaborator

Hellowlol commented Jun 27, 2022

Thanks for the PR. As I mentioned in the issue. I want to use the template for this.

https://github.com/custom-components/nordpool/blob/master/custom_components/nordpool/sensor.py#L268-L270
I pretty use we can just add the current_hours_price async_render function :)

@Hellowlol
Copy link
Collaborator

Closing this in favor of #165 as i dont want to add more config options and adding price to the template allows more flexibility .

Thanks for the PR

@Hellowlol Hellowlol closed this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants