Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FilterSelects CSS specificity #5440

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

mcwinter07
Copy link
Contributor

Why

This is a interim fix while we resolve the issue of our dist's styles.css being compiled out of order, which seems to primarily impact the Filter Select component due to the low specificity of its styles.

What

  • converts FilterSelect and Filter SCSS to CSS
  • updates FilterSelect's classNameOverride to double up on specificity

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: cc077cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcwinter07 mcwinter07 marked this pull request as ready for review January 7, 2025 22:04
@mcwinter07 mcwinter07 requested a review from a team as a code owner January 7, 2025 22:04
@mcwinter07 mcwinter07 requested a review from dougmacknz January 7, 2025 22:04
Copy link
Contributor

github-actions bot commented Jan 7, 2025

✨ Here is your branch preview! ✨

Last updated for commit cc077cb: remove unused class from FilterSelect

@mcwinter07 mcwinter07 force-pushed the KZN-2925/filter-content-css-specificity branch from 2c6eea3 to a4ec440 Compare January 8, 2025 00:34
@mcwinter07 mcwinter07 force-pushed the KZN-2925/filter-content-css-specificity branch from a4ec440 to cc077cb Compare January 8, 2025 00:35
@mcwinter07 mcwinter07 requested a review from dougmacknz January 8, 2025 00:36
@mcwinter07 mcwinter07 merged commit 2f03f04 into main Jan 8, 2025
19 checks passed
@mcwinter07 mcwinter07 deleted the KZN-2925/filter-content-css-specificity branch January 8, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants