Button v3 Tertiary Styles Update #5399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 260b077 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
#5395) * Menu: Create MenuPopover, MenuSection and MenuHeader wrappers over RAC * Update docs
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mcwinter07
previously approved these changes
Dec 17, 2024
* refactor: rename __future__ dir to __rc__ * refactor(Tooltip): move v1/v2 to src * refactor(Tooltip): move v3 to rc * refactor(Focusable): move into subcomponents of Tooltip * refactor(Button): move v1/v2 to src * refactor(Button): move v3 to rc * refactor(Menu): move v1/v2 to src * refactor(Menu): move v3 to rc
* chore(eslint): enable consistent-type-imports * style: fix linting errors
mcwinter07
reviewed
Dec 18, 2024
mcwinter07
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Button v3 has different styling.
https://cultureamp.atlassian.net/browse/KZN-2918
What
Updated colors for tertiary buttons
Chromatic: https://www.chromatic.com/review?appId=60a1e4a102f0cb003b5d19d6&number=5399&type=linked