Fix removeToastNotification to use previousState #5069
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Request PR reviews on Slack
Please reach out to the design system team on Slack in
#prod_design_system
for PR reviews. GitHub notifications (e.g. from tagging a person) are not actively monitored.Why
When we had multiple toast's on a page, all with different id's, calling
removeToastNotification
would remove all toast's after the one that was being deleted.The toast's all have a button inside them that when clicked will call removeToastNotification.
This is a similar problem to what we were having with
addToastNotification
which we fixed hereWhat
New
By using the previousState syntax of setState, the
notifications
in theremoveToastNotification
is always updated and correct.Old
It appears that the copy of the state that was being created wasn't correct, it hadn't been updated yet before being sliced.