KZN-2527/progressbar-rename-mood-to-color #4919
Conversation
🦋 Changeset detectedLatest commit: 267cb49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/components/codemods/migrateProgressBarMoodToColor/index.ts
Outdated
Show resolved
Hide resolved
packages/components/codemods/migrateProgressBarMoodToColor/index.ts
Outdated
Show resolved
Hide resolved
…ex.ts Co-authored-by: Cassandra <cassandra.tam@cultureamp.com>
…ex.ts Co-authored-by: Cassandra <cassandra.tam@cultureamp.com>
…m:cultureamp/kaizen-design-system into KZN-2527/progressbar-rename-mood-to-color
packages/components/src/ProgressBar/_docs/ProgressBar.stickersheet.stories.tsx
Show resolved
Hide resolved
| label: "25%", | ||
| value: 25, | ||
| max: 100, | ||
| isAnimating: false, |
There was a problem hiding this comment.
Suggestion (although perhaps create a constant instead of calling the function multiple times):
| isAnimating: false, | |
| isAnimating: isChromatic(), |
There was a problem hiding this comment.
It's a stickersheet only for chromatic, maybe not worth ever setting it to true?
There was a problem hiding this comment.
Moreso just for manually checking for yourself :)
But oops, just realised I meant the opposite 😂 It was supposed to be !isChromatic(), so that we disable animation for Chromatic, but can see it ourselves.
There was a problem hiding this comment.
Added an extra example for this instead of making them all animate on local
packages/components/src/ProgressBar/_docs/ProgressBar.stories.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Cassandra <cassandra.tam@cultureamp.com>
Co-authored-by: Cassandra <cassandra.tam@cultureamp.com>
Co-authored-by: Cassandra <cassandra.tam@cultureamp.com>
Co-authored-by: Cassandra <cassandra.tam@cultureamp.com>
Co-authored-by: Cassandra <cassandra.tam@cultureamp.com>
Why
Moving away from
moodWhat
moodcolorprop