feat: translate embedded text within FMS SearchInput #4773
Conversation
🦋 Changeset detectedLatest commit: 947d770 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| const placeholder = formatMessage({ | ||
| id: "filterMultiSelectSearchInput.placeholder", | ||
| defaultMessage: "Search…", | ||
| description: "Placeholder for the search input", |
There was a problem hiding this comment.
Do you think this will be enough for the translation context? I always feel like with less content that's being translated we should provide more context for it - then again, in the grand scheme of this is a placeholder text and it is a generic prompt, sooo maybe give it a crack and see if they respond needing more context :)
There was a problem hiding this comment.
No idea tbh. Happy to change it if you can think of something more detailed to put. I couldn't think of how else to describe it though 😂
There was a problem hiding this comment.
Little verbose but maybe something like "Placeholder text for a search input to prompt users to enter a search term"? Not essential maybe lets add it and see if any issues arise
Why
KZN-2449
Support request. Customer noticed some strings in FilterMultiSelect were not translated.
What
Translate embedded text in:
FilterMultiSelect.SearchInputInputSearch