Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TitleBlockZen): update title font to match composable header #4772

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

HeartSquared
Copy link
Contributor

@HeartSquared HeartSquared commented Jun 18, 2024

What

Update TitleBlockZen's title font to match the composable header.

Why

Match the font family of the composable header.

After discussion with Dave, removed breadcrumb breakpoint title font scaling given:

  • We don't know the actual use case it was solving
  • The change of font changes the width of the text - therefore may already be solving initial reason for it
  • The breakpoint being at 1644 means most users never actually see the proper visual hierarchy, which isn't ideal

@HeartSquared HeartSquared requested a review from a team as a code owner June 18, 2024 01:30
Copy link

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: c36e5ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 18, 2024

✨ Here is your branch preview! ✨

Last updated for commit c36e5ae: feat(TitleBlockZen): remove breadcrumb breakpoint title font scaling

Copy link
Contributor

@dougmacknz dougmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HeartSquared HeartSquared merged commit 9dac69a into main Jun 21, 2024
17 checks passed
@HeartSquared HeartSquared deleted the KZN-2446/update-title-block-header branch June 21, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants