Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EmptyState): Blank out alt text for illustrations in EmptyState #4742

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

dougmacknz
Copy link
Contributor

Illustrations in Empty States have alt text at the moment, when isAnimated is false. It uses the string of the mood prop. e.g. positive or action.

We want these blank because they're decorative

Before

image

After

image

@dougmacknz dougmacknz requested a review from a team as a code owner June 5, 2024 06:01
Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: 5c08ed3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougmacknz dougmacknz force-pushed the dug/blank-alt-text-for-empty-state-img branch from 7bcd2b9 to 3ebb6fa Compare June 5, 2024 06:03
Copy link
Contributor

github-actions bot commented Jun 5, 2024

✨ Here is your branch preview! ✨

Last updated for commit 5c08ed3: fix(EmptyState): Blank out alt text for illustrations in EmptyState

@dougmacknz dougmacknz force-pushed the dug/blank-alt-text-for-empty-state-img branch from 3ebb6fa to 5c08ed3 Compare June 5, 2024 06:06
@gyfchong gyfchong merged commit fc8920c into main Jun 5, 2024
17 checks passed
@gyfchong gyfchong deleted the dug/blank-alt-text-for-empty-state-img branch June 5, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants