Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RTE LinkModal validation response #4730

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

mcwinter07
Copy link
Contributor

Why

  • The current LinkModal in the RichTextEditor does not provide enough context for the user as to the validation method.

Context

  • HTTP and HTTPS is currently required to ensure executable Javascript is not passed into the link
    • It is a simple validation function that we could potentially open up as a prop folks need to build upon it / find it too limiting, but at time of development this was considered enough to ensure security

Note

We haven't been able to get confirmation on the wording from the content team, but we're going to forge ahead with this since its been sitting with us for a while and some clarity is better than none

What

  • Updates the link validation message
  • Updates the description
  • Add simple stories to cover the render states of the link modal

@mcwinter07 mcwinter07 requested a review from a team as a code owner May 29, 2024 07:07
Copy link

changeset-bot bot commented May 29, 2024

🦋 Changeset detected

Latest commit: 5f6f2f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcwinter07 mcwinter07 changed the title Update link validation response Update RTE LinkModal validation response May 29, 2024
Copy link
Contributor

github-actions bot commented May 29, 2024

✨ Here is your branch preview! ✨

Last updated for commit 5f6f2f1: Merge branch 'main' into KZN-2351/update-link-validation-response

@mcwinter07 mcwinter07 force-pushed the KZN-2351/update-link-validation-response branch from 3494278 to 4afa09a Compare May 31, 2024 01:36
@mcwinter07 mcwinter07 force-pushed the KZN-2351/update-link-validation-response branch from 4afa09a to d998738 Compare May 31, 2024 03:33
gyfchong
gyfchong previously approved these changes Jun 3, 2024
@mcwinter07 mcwinter07 merged commit 3be8532 into main Jun 3, 2024
17 checks passed
@mcwinter07 mcwinter07 deleted the KZN-2351/update-link-validation-response branch June 3, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants