Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ThumbUp and ThumbsDown icon set #4561

Merged
merged 12 commits into from
Mar 12, 2024
Merged

Conversation

mcwinter07
Copy link
Contributor

@mcwinter07 mcwinter07 commented Mar 8, 2024

Why

  • Request for a new set of thumbs up and down with on and off states

What

  • Adds new thumbs up and down SVGs with on and off state to assets.
    • These have been manually modified to remove the mask that was causing clipping issues.
      • The investigation as to why the Figma export included this, which is seemingly unnecessary is not in scope of this ticket.
  • Removes old thumbs up and down SVGs from assets.
    • This will not remove the component but does mean it won't be recreated when we run the update script.
    • The .tsx component from these now have a @deprecated doc block pointing to the new ones.
  • Adds ts-node as a dev dep for Kaizen/components so we can run the update-icons script without a global dependency.
  • Some clean up of the Icon reference story.
    • Add a basic filter to remove deprecated components from the story
    • Removes broken search that doesn't bring a lot of functionality.
    • Updates icon cards to make them more readable in their alignment.

Out of scope

  • Investigating out why the Figma export for these icons needed to be manually fixed
  • Refactoring the reference page to look more like the grouping in Figma
    • This is worth revisiting when / if we take a deeper dive into icons and can collab more closely with design
  • Updating icon internals outside of the ThumbsUp and Down variants
    • We should run the update icons as a separate script to let SVGo update the internals for all icons to reduce the risk against missed changes in chromatic

@mcwinter07 mcwinter07 requested a review from a team as a code owner March 8, 2024 03:22
Copy link

changeset-bot bot commented Mar 8, 2024

🦋 Changeset detected

Latest commit: e302dbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcwinter07 mcwinter07 force-pushed the KZN-2165/add-new-icons branch from 8f1d06c to 1282f9d Compare March 8, 2024 03:39
@mcwinter07 mcwinter07 changed the title Kzn 2165/add new icons Add new ThumbUp and ThumbsDown icon set Mar 8, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

✨ Here is your branch preview! ✨

Last updated for commit e302dbe: add small style fix for centering in chromium browsers

@mcwinter07
Copy link
Contributor Author

Noting here that there's many minor changes outline in the diff for all other icon components. This is likely a result of SVGO being updated since it was last run, which has removed some more SVG bloat. Based on the chromatic snapshot, this does visually impact or change the behavior of our icons

package.json Outdated Show resolved Hide resolved
packages/components/src/Icon/AddLinkIcon.tsx Outdated Show resolved Hide resolved
packages/components/src/Icon/_docs/Icon.stories.tsx Outdated Show resolved Hide resolved
packages/components/src/Icon/_docs/icon.stories.scss Outdated Show resolved Hide resolved
@mcwinter07 mcwinter07 force-pushed the KZN-2165/add-new-icons branch from c3a3391 to ef7f94e Compare March 11, 2024 23:54
@mcwinter07 mcwinter07 force-pushed the KZN-2165/add-new-icons branch from ef7f94e to 59cbb89 Compare March 12, 2024 00:48
@mcwinter07 mcwinter07 requested a review from HeartSquared March 12, 2024 00:53
Co-authored-by: Cassandra <cassandra.tam@cultureamp.com>
@mcwinter07 mcwinter07 force-pushed the KZN-2165/add-new-icons branch 2 times, most recently from e5d4c48 to 09426eb Compare March 12, 2024 02:35
@mcwinter07 mcwinter07 force-pushed the KZN-2165/add-new-icons branch from 09426eb to e302dbe Compare March 12, 2024 02:47
@mcwinter07 mcwinter07 merged commit 0b85a5e into main Mar 12, 2024
16 checks passed
@mcwinter07 mcwinter07 deleted the KZN-2165/add-new-icons branch March 12, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants