fix: unscrollable style remains when modal is unmounted #4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 927054b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dougmacknz
reviewed
Feb 21, 2024
dougmacknz
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Request PR reviews on Slack
Please reach out to the design system team on Slack in
#prod_design_systemfor PR reviews. GitHub notifications (e.g. from tagging a person) are not actively monitored.Why
There is a bug when modal is unmounted (e.g. navigation, parent unmounted) after onConfirm, the unscrollable style remains which stops user from scrolling unless refresh.
What
Include the clean up code in onAfterLeave to a useEffect's return block.
Before
Screen.Recording.2024-02-21.at.15.03.19.mov
After
Screen.Recording.2024-02-21.at.14.57.38.mov