Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ids to title block zen #4469

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Conversation

louiseliang
Copy link
Contributor

@louiseliang louiseliang commented Jan 10, 2024

Why

To manage the focus when close a modal/drawer, ids are required to be exposed in TitleblockZen's subcomponents.

What

<MenuItem>: accept id in props and pass it to child button/link
<TitleBlockZen>

  • Add constant ids for TitleBlockZen's secondary menu and other actions menu in mobile view
  • accept id in props to be assigned to the root div

@louiseliang louiseliang requested a review from a team as a code owner January 10, 2024 05:21
Copy link

changeset-bot bot commented Jan 10, 2024

🦋 Changeset detected

Latest commit: b9c1574

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@louiseliang louiseliang self-assigned this Jan 10, 2024
Copy link
Contributor

github-actions bot commented Jan 10, 2024

✨ Here is your branch preview! ✨

Last updated for commit b9c1574: chore: prettier

Copy link
Contributor

@dougmacknz dougmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@dougmacknz dougmacknz merged commit aebd4d3 into main Jan 10, 2024
17 checks passed
@dougmacknz dougmacknz deleted the ll/add-ids-to-TitleBlockZen branch January 10, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants