Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LikertScaleLegacy #4253

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Conversation

gyfchong
Copy link
Contributor

@gyfchong gyfchong requested a review from a team as a code owner October 31, 2023 23:14
Copy link

changeset-bot bot commented Oct 31, 2023

🦋 Changeset detected

Latest commit: 15a5d38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 31, 2023

✨ Here is your branch preview! ✨

Last updated for commit 15a5d38: add hardcoded example for story


export const Playground: Story = {
render: args => {
const [selectedItem, setSelectedItem] = useState<ScaleItem | null>(null)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debating whether or not I should make the Playground work...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The story seems to work on the mdx page 😄 or do you mean show we not have it work because its a legacy likert scale?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it work, but I'm debating removing the functionality in the example cause it might imply no effort on the consumer side to make it work in their code base...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah gotcha. Couldn't we update the canvas src to showcase the mimimum code required to get that story up and running?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I guess there's not much to toggle in controls, so may as well hardcode it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 I can't imagine it changing so I think that should be good

@gyfchong gyfchong merged commit 880e668 into main Nov 2, 2023
15 checks passed
@gyfchong gyfchong deleted the KDS-1875-migrate-likert-scale-legacy-1 branch November 2, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants