-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add LikertScaleLegacy #4253
add LikertScaleLegacy #4253
Conversation
🦋 Changeset detectedLatest commit: 15a5d38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
||
export const Playground: Story = { | ||
render: args => { | ||
const [selectedItem, setSelectedItem] = useState<ScaleItem | null>(null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debating whether or not I should make the Playground work...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The story seems to work on the mdx page 😄 or do you mean show we not have it work because its a legacy likert scale?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it work, but I'm debating removing the functionality in the example cause it might imply no effort on the consumer side to make it work in their code base...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah gotcha. Couldn't we update the canvas src to showcase the mimimum code required to get that story up and running?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm I guess there's not much to toggle in controls, so may as well hardcode it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 I can't imagine it changing so I think that should be good
Why
Migration!
What
LikertScaleLegacy
https://cultureamp.design/?path=/docs/legacy_components-likert-scale--docs