Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Toast Notifications #4246

Merged
merged 11 commits into from
Nov 2, 2023
Merged

Migrate Toast Notifications #4246

merged 11 commits into from
Nov 2, 2023

Conversation

mcwinter07
Copy link
Contributor

@mcwinter07 mcwinter07 commented Oct 30, 2023 •
edited by HeartSquared
Loading

Why

Part of the Migration to KAIO

What

  • Replace ReactDOM.render with createRoot
  • Remove deprecated autohide functionality
    • Add notes in documentation on a11y risk and reason for removal
  • Update test description and cover a few more of scenarios
  • Update documentation of API with more descriptions exported methods
  • Split ToastNotificationsListContainer and ToastNotificationsList into two separate sub-components
    • Originally these were both exported from the same file - this is just a bit of house keeping to make it easier to read

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: ed6b068

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcwinter07 mcwinter07 marked this pull request as ready for review October 30, 2023 01:21
@mcwinter07 mcwinter07 requested a review from a team as a code owner October 30, 2023 01:21
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023 •
edited
Loading

✨ Here is your branch preview! ✨

Last updated for commit ed6b068: Merge branch 'main' into KDS-1749/migrate-toast-notifications

HeartSquared
HeartSquared reviewed Oct 30, 2023
View reviewed changes
.changeset/metal-snakes-crash.md Outdated Show resolved Hide resolved
packages/components/src/Notification/ToastNotification/ToastNotification.tsx Outdated Show resolved Hide resolved
...mponents/src/Notification/ToastNotification/_docs/ToastNotification.stickersheet.stories.tsx Outdated Show resolved Hide resolved
...mponents/src/Notification/ToastNotification/_docs/ToastNotification.stickersheet.stories.tsx Outdated Show resolved Hide resolved
packages/components/src/Notification/ToastNotification/_docs/ToastNotification.stories.tsx Outdated Show resolved Hide resolved
packages/components/src/Notification/ToastNotification/_docs/ToastNotification.stories.tsx Outdated Show resolved Hide resolved
packages/components/src/Notification/ToastNotification/index.ts Outdated Show resolved Hide resolved
...n/ToastNotification/subcomponents/ToastNotificationManager/ToastNotificationManager.spec.tsx Outdated Show resolved Hide resolved
packages/components/src/Notification/ToastNotification/types.ts Show resolved Hide resolved
@HeartSquared
Copy link
Contributor

Is it just me, or are the Chromatic snapshots empty?

@gyfchong
Copy link
Contributor

Chromatic is empty

@mcwinter07 mcwinter07 force-pushed the KDS-1749/migrate-toast-notifications branch 2 times, most recently from 1d9aa7d to ba3d519 Compare October 31, 2023 05:40
@mcwinter07 mcwinter07 force-pushed the KDS-1749/migrate-toast-notifications branch from a1a0a47 to 331e580 Compare November 1, 2023 00:26
@mcwinter07 mcwinter07 force-pushed the KDS-1749/migrate-toast-notifications branch from bb85100 to 9e697d8 Compare November 2, 2023 04:56
@mcwinter07 mcwinter07 enabled auto-merge (squash) November 2, 2023 05:06
@mcwinter07 mcwinter07 merged commit b01fc8a into main Nov 2, 2023
15 checks passed
@mcwinter07 mcwinter07 deleted the KDS-1749/migrate-toast-notifications branch November 2, 2023 05:18
@github-actions github-actions bot mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougmacknz dougmacknz dougmacknz left review comments

@gyfchong gyfchong gyfchong left review comments

@HeartSquared HeartSquared HeartSquared approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcwinter07 @HeartSquared @gyfchong @dougmacknz