Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDS-1756-migrate-skirt-content-to-kaio-2 #4211

Merged
merged 8 commits into from
Oct 26, 2023

Conversation

gyfchong
Copy link
Contributor

No description provided.

@gyfchong gyfchong requested a review from a team as a code owner October 26, 2023 00:23
@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

🦋 Changeset detected

Latest commit: 1657fea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

component: Skirt,
args: {
children: (
<SkirtCard>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Story looks weird without the TitleBlock will most likely add the Titleblock in here when its migrated.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

✨ Here is your branch preview! ✨

Last updated for commit 1657fea: Remove duplicate to save some money

HeartSquared
HeartSquared previously approved these changes Oct 26, 2023
Copy link
Contributor

@HeartSquared HeartSquared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's necessary to send both stories for Content and Container to Chromatic given they're exactly the same.

@gyfchong gyfchong merged commit 0bc4936 into main Oct 26, 2023
15 checks passed
@gyfchong gyfchong deleted the KDS-1756-migrate-skirt-content-to-kaio-2 branch October 26, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants