Fix-circular-dependencies #3955
Conversation
🦋 Changeset detectedLatest commit: 716f218 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…zen-design-system into fix-circular-dependencies
| @@ -1 +1,2 @@ | |||
| export * from "./Button" | |||
| export * from "./components/GenericButton" | |||
There was a problem hiding this comment.
Does this mean we're now exporting the GenericButton? Makes sense for exporting the types but I wonder if it mean peeps will start trying to consume this / or if it was possible to access this before 🤔
There was a problem hiding this comment.
Doesn't look like GenericButton was available before, but this approach aligns with the new development pattern where we export internals to allow for custom builds.
If consumers actually need a custom button, then they should be able to create one. Not that the GenericButton is particularly good lol
There was a problem hiding this comment.
True, wasn't sure if we wanted to offer it but certainly not apposed 👍
Why
We shouldn't have circular deps
What
Switched importing of components and types to rely on the source which exports it, rather than the root level
indexwhich also exports the same things.Note
Couldn't figure out the
FilterBarcircular types dep :(