fix(filter-bar): enable sibling value dependent filters #3847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 338cc8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gyfchong
reviewed
Jul 6, 2023
abd4f38 to
2301e92
Compare
…ms have not changed
…longer exists in items
2301e92 to
eff562a
Compare
mcwinter07
reviewed
Jul 6, 2023
packages/components/src/FilterBar/subcomponents/FilterBarMultiSelect/FilterBarMultiSelect.tsx
Show resolved
Hide resolved
mcwinter07
approved these changes
Jul 6, 2023
| itemValues.includes(value) | ||
| ) | ||
|
|
||
| if (!checkArraysMatch(filterState.value, filteredValues)) { |
There was a problem hiding this comment.
Nice, no more engineers in the building! 😉
Translation: Nice, should be a less brittle way to update those values 🕺
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enable Select/MultiSelect filters to load items based on a sibling's selected value.
Why
KDS-1475
Common use case for consumers.