Kds 1394 i 18 n for filter drp #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8ac9d11 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…o KDS-1394-i-18-n-for-filter-drp
…p/kaizen-design-system into KDS-1394-i-18-n-for-filter-drp
gyfchong
reviewed
Jul 7, 2023
gyfchong
reviewed
Jul 10, 2023
| @@ -140,6 +141,42 @@ Playground.args = { | |||
| renderTrigger: "Filter Button", | |||
| } | |||
|
|
|||
| export const Translated: StoryFn<typeof FilterDateRangePicker> = args => { | |||
There was a problem hiding this comment.
Is this supposed to be sent to Chromatic? Probably add it to the stickersheet
2bfb88d to
8ac9d11
Compare
gyfchong
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
FilterDRP has hard-coded strings that can only be translated from within KZ.
What
useIntlfunction from@cultureamp/i18n-react-intl, as our jest environment doesn't have an intl object in context@kaizen/components, so they can be compiled with consuming repo's locales@cultureamp/i18n-react-intl