Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the future release /dist reference path in package.json #3786

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

mcwinter07
Copy link
Contributor

@mcwinter07 mcwinter07 commented Jun 22, 2023

Why

The dist reference paths did not align to the outputs and we could not import components from the future folder.

{
  "main": "../dist/__future__/index.js",
  "module": "../dist/esm/__future__/index.js",
  "types": "../dist/__future__/index.d.ts"
}

This is a small fix to update the paths to the future.js file in the esm and cjs folders, and the types pulled from esm/dts/__future__

Before

Screenshot 2023-06-22 at 11 35 18 am

After

Screenshot 2023-06-22 at 11 34 34 am

What

  • updates @kaizen/components future package.json

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023

🦋 Changeset detected

Latest commit: 2249a3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcwinter07 mcwinter07 marked this pull request as ready for review June 22, 2023 01:36
@mcwinter07 mcwinter07 requested a review from a team as a code owner June 22, 2023 01:36
@github-actions
Copy link
Contributor

✨ Here is your branch preview! ✨

Last updated for commit 2249a3e: update the future release /dist reference path in package.json

@mcwinter07 mcwinter07 requested a review from gyfchong June 22, 2023 01:37
"types": "../dist/__future__/index.d.ts"
"main": "../dist/cjs/future.js",
"module": "../dist/esm/future.js",
"types": "../dist/esm/dts/__future__/index.d.ts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in a weird place though lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I figured we could take a crack at updating the output path or creating a future.d.ts when we loop back to the tooling health day :)

@mcwinter07 mcwinter07 merged commit bbb569f into main Jun 22, 2023
@mcwinter07 mcwinter07 deleted the KDS-1557/update-future-dist-refence-path branch June 22, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants