IDE-Checks

cuioss · Feb 18, 2025 · eba1d79 · eba1d79
1 parent b2c6937
commit eba1d79
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 65 deletions.
diff --git a/src/test/java/de/cuioss/uimodel/field/impl/BaseDynamicFieldTest.java b/src/test/java/de/cuioss/uimodel/field/impl/BaseDynamicFieldTest.java
@@ -15,20 +15,18 @@
  */
 package de.cuioss.uimodel.field.impl;
 
+import de.cuioss.test.valueobjects.ValueObjectTest;
+import de.cuioss.test.valueobjects.api.contracts.VerifyConstructor;
+import de.cuioss.uimodel.field.DynamicFieldType;
+import org.junit.jupiter.api.Test;
+
 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-
-import org.junit.jupiter.api.Test;
-
-import de.cuioss.test.valueobjects.ValueObjectTest;
-import de.cuioss.test.valueobjects.api.contracts.VerifyConstructor;
-import de.cuioss.uimodel.field.DynamicFieldType;
-
 @VerifyConstructor(of = {"editable"})
 @VerifyConstructor(of = {"value", "editable"})
 class BaseDynamicFieldTest extends ValueObjectTest<StringEditableField> {
@@ -42,7 +40,7 @@ void shouldConstructIntegerField() {
         assertTrue(editableField.isAvailable());
         assertTrue(editableField.isChanged());
         // Different constructor
-        editableField = new IntegerEditableField(1, false);
+        assertDoesNotThrow(() -> new IntegerEditableField(1, false));
     }
 
     @Test
@@ -55,7 +53,7 @@ void shouldConstructStringField() {
         assertTrue(editableField.isChanged());
 
         // Different constructor
-        editableField = new StringEditableField("1", false);
+        assertDoesNotThrow(() -> new StringEditableField("1", false));
     }
 
     @Test
@@ -68,7 +66,7 @@ void shouldConstructBooleanField() {
         assertTrue(editableField.isChanged());
 
         // Different constructor
-        editableField = new BooleanEditableField(Boolean.TRUE, false);
+        assertDoesNotThrow(() -> new BooleanEditableField(Boolean.TRUE, false));
     }
 
     @Test
@@ -81,7 +79,7 @@ void shouldConstructDoubleField() {
         assertTrue(editableField.isChanged());
 
         // Different constructor
-        editableField = new DoubleEditableField(2d, false);
+        assertDoesNotThrow(() -> new DoubleEditableField(2d, false));
     }
 
     @Test
@@ -94,7 +92,7 @@ void shouldConstructFloatField() {
         assertTrue(editableField.isChanged());
 
         // Different constructor
-        editableField = new FloatEditableField(1f, false);
+        assertDoesNotThrow(() -> new FloatEditableField(1f, false));
     }
 
     @Test
@@ -107,7 +105,7 @@ void shouldConstructLongField() {
         assertTrue(editableField.isChanged());
 
         // Different constructor
-        editableField = new LongEditableField(1L, false);
+        assertDoesNotThrow(() -> new LongEditableField(1L, false));
     }
 
     @Test

diff --git a/src/test/java/de/cuioss/uimodel/nameprovider/DisplayNameProviderGenerator.java b/src/test/java/de/cuioss/uimodel/nameprovider/DisplayNameProviderGenerator.java
diff --git a/src/test/java/de/cuioss/uimodel/nameprovider/I18nDisplayNameProviderTest.java b/src/test/java/de/cuioss/uimodel/nameprovider/I18nDisplayNameProviderTest.java
@@ -15,12 +15,12 @@
  */
 package de.cuioss.uimodel.nameprovider;
 
-import static org.hamcrest.MatcherAssert.assertThat;
-import static org.hamcrest.core.Is.is;
-import static org.hamcrest.core.IsNull.nullValue;
-import static org.hamcrest.core.StringContains.containsString;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.fail;
+import de.cuioss.test.valueobjects.ValueObjectTest;
+import de.cuioss.test.valueobjects.api.property.PropertyReflectionConfig;
+import de.cuioss.uimodel.nameprovider.I18nDisplayNameProvider.Builder;
+import de.cuioss.uimodel.nameprovider.testdata.ConfiguredDataGenerator;
+import de.cuioss.uimodel.nameprovider.testdata.DemoTransformationFunction;
+import org.junit.jupiter.api.Test;
 
 import java.util.HashMap;
 import java.util.HashSet;
@@ -29,14 +29,12 @@
 import java.util.Map.Entry;
 import java.util.Set;
 
-
-import org.junit.jupiter.api.Test;
-
-import de.cuioss.test.valueobjects.ValueObjectTest;
-import de.cuioss.test.valueobjects.api.property.PropertyReflectionConfig;
-import de.cuioss.uimodel.nameprovider.I18nDisplayNameProvider.Builder;
-import de.cuioss.uimodel.nameprovider.testdata.ConfiguredDataGenerator;
-import de.cuioss.uimodel.nameprovider.testdata.DemoTransformationFunction;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.core.Is.is;
+import static org.hamcrest.core.IsNull.nullValue;
+import static org.hamcrest.core.StringContains.containsString;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.fail;
 
 @PropertyReflectionConfig(skip = true)
 class I18nDisplayNameProviderTest extends ValueObjectTest<I18nDisplayNameProvider> {
@@ -86,9 +84,9 @@ void shouldCreateProviderOnValidInitialization() {
     @Test
     void shouldCreateProviderWithTransformation() {
         final var data = new ConfiguredDataGenerator().next();
-        final var transormationFunction = new DemoTransformationFunction();
+        final var transformationFunction = new DemoTransformationFunction();
 
-        final var provider = createBuilder().transformAndAddAll(data, transormationFunction).build();
+        final var provider = createBuilder().transformAndAddAll(data, transformationFunction).build();
 
         assertThat(provider.getContent().get(Locale.ENGLISH), is("[en] text"));
         assertThat(provider.getContent().get(Locale.UK), is("[en_GB] text"));
@@ -105,14 +103,14 @@ void shouldProvideFallbackLookup() {
 
         final var provider = builder.build();
 
-        // short cut method usage
+        // shortcut method usage
         assertThat(provider.lookupTextFor(Locale.GERMANY), is("[de_DE] text"));
         assertThat(provider.lookupTextFor(Locale.UK), is("[en_GB] text"));
 
         assertThat(provider.lookupTextFor(Locale.ENGLISH), is(nullValue()));
         assertThat(provider.lookupTextFor(Locale.GERMAN), is(nullValue()));
 
-        // short cut method with fallback
+        // shortcut method with fallback
         assertThat(provider.lookupTextWithFallbackFirstFittingLanguageOnly(Locale.ENGLISH), is("[en_GB] text"));
         assertThat(provider.lookupTextWithFallbackFirstFittingLanguageOnly(Locale.GERMAN), is("[de_DE] text"));
         assertThat(provider.lookupTextFor(Locale.CHINESE), is(nullValue()));